EndzeitBegins commented on PR #9477: URL: https://github.com/apache/nifi/pull/9477#issuecomment-2450574494
I've seen projects having a dedicated `ci` or `jenkins` directory in the past. That's what I was thinking about. Another thing that comes to mind is that users might want to store automated tests for a Flow inside the same repository as the Flow. However, as both the `GitLabFlowRegistryProvider` and `GitHubFlowRegistryProvider` are still very new it might be fair to assume that users can still opt for an explicit repository path in case they use non-"hidden" directories, as you've outlined above. Keeping the configuration as simple as possible sounds reasonable. Should the need arise in the future, we still could introduce a property later on while preserving the now statically defined behaviour. Having said that I'm now in favour of this change as is. Thank you for the contribution once more @pvillard31. Code changes look straightforward. Does it make sense to manifest the behaviour with a test case though, to ensure it's not altered by accident in the future? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
