lordgamez commented on code in PR #1889:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1889#discussion_r1827837205
##########
extensions/python/CMakeLists.txt:
##########
@@ -38,9 +41,7 @@ endif()
target_compile_definitions(minifi-python-script-extension PUBLIC
PY_SSIZE_T_CLEAN)
target_sources(minifi-python-script-extension PRIVATE ${PY_SOURCES})
-if (CMAKE_SYSTEM_NAME STREQUAL "Linux")
- target_link_libraries(minifi-python-script-extension PUBLIC
-Wl,--no-as-needed ${Python_LIBRARIES} -Wl,--as-needed)
-else()
+if (WIN32 OR APPLE)
Review Comment:
Updated in 86d74091401fb65ad261f0a289ee4634f743cb25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
