mcgilman commented on code in PR #9480:
URL: https://github.com/apache/nifi/pull/9480#discussion_r1829426680
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/extension-creation/extension-creation.component.html:
##########
@@ -15,23 +15,26 @@
~ limitations under the License.
-->
<div class="extension-creation-dialog" (keyup)="navigateSelectionList($event)">
- <div class="flex justify-between items-center">
- <h2 mat-dialog-title>Add {{ componentType }}</h2>
- <div class="pt-5 pr-5">
- <mat-form-field>
- <mat-label>Filter types</mat-label>
- <input
- matInput
- class="px-1.5 py-1 w-64"
- type="text"
- (keyup)="filterTypes($event)"
- tabindex="0"
- placeholder="Filter types..." />
- </mat-form-field>
- </div>
- </div>
+ <h2 mat-dialog-title>Add {{ componentType }}</h2>
<mat-dialog-content>
- <div class="flex flex-col dialog-content">
+ <div class="flex flex-col dialog-content gap-y-2">
+ <div class="flex flex-col">
+ <div class="flex items-center gap-x-2">
+ <mat-form-field subscriptSizing="dynamic" class="mt-1">
+ <mat-label>Filter types</mat-label>
+ <input
+ matInput
+ class="px-1.5 py-1 w-64"
+ type="text"
+ (keyup)="filterTypes($event)"
+ tabindex="0"
+ placeholder="Filter types..." />
+ </mat-form-field>
+ </div>
+ <div class="tertiary-color font-medium mt-2">
Review Comment:
Can we use `gap-y-2` on this elements parent instead of `mt-2` here?
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/extension-creation/extension-creation.component.html:
##########
@@ -15,23 +15,26 @@
~ limitations under the License.
-->
<div class="extension-creation-dialog" (keyup)="navigateSelectionList($event)">
- <div class="flex justify-between items-center">
- <h2 mat-dialog-title>Add {{ componentType }}</h2>
- <div class="pt-5 pr-5">
- <mat-form-field>
- <mat-label>Filter types</mat-label>
- <input
- matInput
- class="px-1.5 py-1 w-64"
- type="text"
- (keyup)="filterTypes($event)"
- tabindex="0"
- placeholder="Filter types..." />
- </mat-form-field>
- </div>
- </div>
+ <h2 mat-dialog-title>Add {{ componentType }}</h2>
<mat-dialog-content>
- <div class="flex flex-col dialog-content">
+ <div class="flex flex-col dialog-content gap-y-2">
+ <div class="flex flex-col">
+ <div class="flex items-center gap-x-2">
Review Comment:
```suggestion
<div class="flex items-center">
```
There is only a single child element so the `gap` isn't needed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
