[
https://issues.apache.org/jira/browse/NIFI-13989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896721#comment-17896721
]
Daniel Stieglitz edited comment on NIFI-13989 at 11/8/24 4:32 PM:
------------------------------------------------------------------
YamlTreeRowRecordReader is also affected with this as it inherits from
JsonTreeRowRecordReader. In addition this refactoring would help if we ever
considered an implementation for TOML NIFI-13919 which I believe would also
inherit from JsonTreeRowRecordReader.
In addition in the past changes were made to this class with NIFI-12153 and
there is an outstanding ticket NIFI-12456 which would necessitate more changes
to this class.
was (Author: JIRAUSER294662):
YamlTreeRowRecordReader is also affected with this as it inherits from
JsonTreeRowRecordReader. In addition this refactoring would help if we ever
considered an implementation for TOML NIFI-13919 which I believe would also
inherit from JsonTreeRowRecordReader.
> Refactor JsonTreeRowRecordReader constructor to take a parameter object
> -----------------------------------------------------------------------
>
> Key: NIFI-13989
> URL: https://issues.apache.org/jira/browse/NIFI-13989
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Daniel Stieglitz
> Assignee: Daniel Stieglitz
> Priority: Minor
>
> When attempting a fix for NIFI-13963 I found it very hard to add another
> argument as there are already 13 arguments for the current constructor. This
> is a code smell Martin Fowler identifies as a long parameter list
> [https://luzkan.github.io/smells/long-parameter-list.|https://luzkan.github.io/smells/long-parameter-list]
> One of the solutions is to create a parameter object to encompass all the
> arguments.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
