[ 
https://issues.apache.org/jira/browse/NIFI-14011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898399#comment-17898399
 ] 

endzeit commented on NIFI-14011:
--------------------------------

@[~exceptionfactory]: I just noticed that, unlike e.g. {{Processor}} and 
{{{}ControllerService{}}}, {{AbstractParameterProvider}} does not actually 
provide a {{migrateProperties}} method. 

So changing the existing names would be a breaking change as of now. Do you 
think we should integrate a migrateProperties for  ParameterProvider as well?

Maybe we should align the new values first and adjust others in a following PR 
while introducing migrateProperties?

> Introduce properties SECRET_LISTING_STRATEGY and SECRET_NAMES with each same 
> name and displayName
> -------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-14011
>                 URL: https://issues.apache.org/jira/browse/NIFI-14011
>             Project: Apache NiFi
>          Issue Type: Task
>            Reporter: endzeit
>            Assignee: endzeit
>            Priority: Major
>
> NIFI-12061 introduced the new properties SECRET_LISTING_STRATEGY and 
> SECRET_NAMES to the AwsSecretsManagerParameterProvider.
> Based on former review feedback, e.g. on 
> [PR#8064|https://github.com/apache/nifi/pull/8064#discussion_r1411195114], 
> the {{name}} and {{displayName}} of newly introduced properties should align 
> and be in Title Case.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to