EndzeitBegins commented on PR #9519: URL: https://github.com/apache/nifi/pull/9519#issuecomment-2478037503
Thank you for the addition @pvillard31. I just glanced over the code, so I might've missed something, but the overall code looked good to me. I just wondered, Is there a particular reason to have a distinct property for adding a `mime.type` attribute? From what I've gathered users can add arbitrary attributes to the resulting FlowFile using dynamic properties. There are other [Core attributes](https://github.com/apache/nifi-api/blob/main/src/main/java/org/apache/nifi/flowfile/attributes/CoreAttributes.java) used quite regularly by other processors, such as `filename`. Just trying to understand, is there a reason we explicitly want / need a property for this particular attribute? If not, we might not introduce a separate property and simplify the implementation even further? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
