exceptionfactory commented on PR #9551: URL: https://github.com/apache/nifi/pull/9551#issuecomment-2513023720
Thanks for the updates @dan-s1. Reviewing the changes locally, everything looked good except for the `TestPutSQL` directory. I made some adjustments to that class using the `FileUtils.deleteDirectory` method for more reliable directory removal, since it remained after the test completed. This worked locally on Linux, so I will review the GitHub workflow build for Windows to confirm it works as expected. It may be necessary to do some additional Derby shutdown calls given Windows behavior, but if the builds pass, I will proceed with merging. I also noticed the `poifiles` directory as you mentioned in the description. It sounds like we may need to revisit this as a runtime setting, but that can be addressed separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
