scottyaslan commented on code in PR #9561: URL: https://github.com/apache/nifi/pull/9561#discussion_r1879311100
########## nifi-frontend/src/main/frontend/apps/update-attribute/src/app/pages/update-attribute/ui/condition-table/condition-table.component.html: ########## @@ -0,0 +1,111 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<div class="condition-table flex flex-col h-full gap-y-2"> + <div class="flex justify-end items-center"> + @if (!isDisabled) { + <button mat-icon-button class="primary-icon-button" type="button" (click)="newConditionClicked()"> Review Comment: Try to create a new rule. There will be an initial 'empty' expression added for the user. Do not add any value and close the editor. Click the button to add another condition. Enter a valid value for this condition. Now try to save. It will fail. Now delete the 'empty' condition. Attempt to save again. Still you will get an error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
