exceptionfactory opened a new pull request, #9581: URL: https://github.com/apache/nifi/pull/9581
# Summary [NIFI-14073](https://issues.apache.org/jira/browse/NIFI-14073) Adds the [Maven PMD Plugin](https://maven.apache.org/plugins/maven-pmd-plugin/) to the set of plugins run as part of the `contrib-check` profile for verifying correctness and style of code changes. The [PMD](https://pmd.github.io/) project augments existing code style evaluation from Checkstyle and introduces tuned analysis rules for catching common problems. Thanks to recent efforts to cleanup and standardize code across the repository, the changes in this pull request are limited to bringing a handful of classes in line with common rules. Most of these changes involve removing or annotating unused private fields, and bringing consistency to the use of generic types. The plugin configuration uses the `pmd-ruleset.xml`, which is based on the default set of rules, but removes some that would have involved too many changes to existing code. The PMD configuration excludes code generated from ANTLR and JAXB plugins from evaluation. Additional changes include simplifying the Maven options for the GitHub `ci-workflow`, removing the need for selective exclusion of certain modules. These adjustments make it easier to run the `pmd:check` goal without a large number of module exclusions. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
