mosermw commented on PR #8362: URL: https://github.com/apache/nifi/pull/8362#issuecomment-2555797145
Thanks for making these changes @Freedom9339. One or two last things that I noticed. When validating a CSV Source Attribute, we can set the "Validation Strategy = Line by line". When we do this, the flowfile content is replaced with the value of the CSV attribute. This is clearly not good! I cannot think of a use case where we want to allow "Validation Strategy = Line by line" on an attribute ... it should always validate the whole attribute and not change anything. We can make the CSV Source Attribute depend on "Validation Strategy = FlowFile" but then we would have to defend ourselves from the case when someone enters a CSV Source Attribute and then changes the Validation Strategy. The CSV Source Attribute will disappear and I'm worried that it will still be set and we will still try to use it. So, if using dependsOn() gets too complicated, just add something to customValidate to disallow CSV Source Attribute with "Validation Strategy = Line by line" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
