szaszm commented on code in PR #1903:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1903#discussion_r1897435674


##########
extensions/ai/CMakeLists.txt:
##########


Review Comment:
   I think AI is too generic for naming the extension and the processor. Let's 
call the extension minifi-llamacpp and the processor something like 
SentimentAnalysisLlamacpp (if that's what it's doing).
   
   (also there's no line ending on the last line)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to