joewitt commented on code in PR #9600:
URL: https://github.com/apache/nifi/pull/9600#discussion_r1898621133
##########
nifi-extension-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/services/azure/eventhub/AzureEventHubRecordSink.java:
##########
@@ -143,7 +143,7 @@ public class AzureEventHubRecordSink extends
AbstractControllerService implement
@Override
protected List<PropertyDescriptor> getSupportedPropertyDescriptors() {
- return PROPERTY_DESCRIPTORS;
+ return PROPERTIES;
Review Comment:
As I look through here it is clearly inconsistent whether we use the term
properties, descriptors, or property descriptors. However, we should be
careful. These things we're messing with in all these files are
PropertyDescriptor objects. They're not actually properties. If we're going
to establish more consistency we should consider using the term DESCRIPTOR or
PROPERTY_DESCRIPTOR but probably not simply PROPERTIES
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
