greyp9 commented on PR #9604:
URL: https://github.com/apache/nifi/pull/9604#issuecomment-2568182241

   > Hello @greyp9, I fixed the test setup, now it should work ;-) Can you 
please review it again?
   
   I just started the automation.
   
   It looks like there is a bit of additional nuance related to the 
`kafka.tombstone` FlowFile attribute.  As you noted in the JIRA, this field is 
currently unused.
   
   It makes sense that `RecordWrapperStreamKafkaRecordConverter` implements the 
tombstone logic.  But if we implement this here, then 
`FlowFileStreamKafkaRecordConverter` should get a corresponding touch.  The 
other two implementations (record and delimited) probably don't need an 
implementation, as those were unimplemented in the old `PublishKafka_2_6`.  The 
relevant code seems to be here:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to