[ 
https://issues.apache.org/jira/browse/NIFI-14140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911634#comment-17911634
 ] 

Daniel Stieglitz edited comment on NIFI-14140 at 1/9/25 7:57 PM:
-----------------------------------------------------------------

How about RemoteProcessGroupResource on line 897

 
{code:java}
Set<RemoteProcessGroupEntity> remoteProcessGroupEntities = _revisions.stream()
                            .map(revision -> {
                                final RemoteProcessGroupEntity entity = 
serviceFacade.updateRemoteProcessGroup(revision, 
createDTOWithDesiredRunStatus(revision.getComponentId(),
                                        remotePortRunStatusEntity));
                                
populateRemainingRemoteProcessGroupEntityContent(entity);
                                return entity;
                            })
                            .collect(Collectors.toSet());
{code}
PMD is reporting remoteProcessGroupEntities is not used. I assume what is 
happening in the mapping is needed but could this happen in a forEach instead 
of a map so no Set would have to be created? For example

 
{code:java}
_revisions.forEach(revision -> {
                                final RemoteProcessGroupEntity entity = 
serviceFacade.updateRemoteProcessGroup(revision, 
createDTOWithDesiredRunStatus(revision.getComponentId(),
                                        remotePortRunStatusEntity));
                                
populateRemainingRemoteProcessGroupEntityContent(entity);
                            });{code}
 


was (Author: JIRAUSER294662):
How about RemoteProcessGroupResource on line 897

 
{code:java}
Set<RemoteProcessGroupEntity> remoteProcessGroupEntities = _revisions.stream()
                            .map(revision -> {
                                final RemoteProcessGroupEntity entity = 
serviceFacade.updateRemoteProcessGroup(revision, 
createDTOWithDesiredRunStatus(revision.getComponentId(),
                                        remotePortRunStatusEntity));
                                
populateRemainingRemoteProcessGroupEntityContent(entity);
                                return entity;
                            })
                            .collect(Collectors.toSet());
{code}
PMD is reporting remoteProcessGroupEntities is not used. I assume what is 
happening in the mapping is needed but could this happen in a forEach instead 
of a map so no Set would have to be created?

 

> Apply PMD's UnusedLocalVariable across the code base
> ----------------------------------------------------
>
>                 Key: NIFI-14140
>                 URL: https://issues.apache.org/jira/browse/NIFI-14140
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Daniel Stieglitz
>            Assignee: Daniel Stieglitz
>            Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to