lordgamez commented on code in PR #1895: URL: https://github.com/apache/nifi-minifi-cpp/pull/1895#discussion_r1916117305
########## libminifi/src/utils/Environment.cpp: ########## @@ -27,9 +27,16 @@ #include <mutex> #include <vector> #include <iostream> +#include <unordered_map> #include "utils/gsl.h" +// Apple doesn't provide the environ global variable +#if defined(__APPLE__) && !defined(environ) +#include <crt_externs.h> +#define environ (*_NSGetEnviron()) Review Comment: Even though it compiled the tests failed on MacOS with this change so I reverted it in https://github.com/apache/nifi-minifi-cpp/pull/1895/commits/1c0186a44f988ee2a3817e74c41eaf6f8651fe34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
