bobpaulin commented on code in PR #9635:
URL: https://github.com/apache/nifi/pull/9635#discussion_r1917253902
##########
nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/credentials/factory/CredentialPropertyDescriptors.java:
##########
@@ -91,4 +91,24 @@ private CredentialPropertyDescriptors() { }
.sensitive(true)
.build();
+ public static final PropertyDescriptor DELEGATION_STRATEGY = new
PropertyDescriptor.Builder()
+ .name("delegation-strategy")
+ .displayName("Delegation Strategy")
Review Comment:
Are we ok if the name doesn't match the convention of the other names in the
class? Or are you asking me to update all the names and create a migrate
properties to ensure older version convert? I understand the desire to get
away from display name just want to ensure we're ok with some of the code
looking patchy or requiring upgrade methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
