lordgamez commented on code in PR #1909:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1909#discussion_r1918104781
##########
libminifi/include/core/state/nodes/FlowInformation.h:
##########
@@ -110,32 +117,17 @@ class FlowMonitor : public StateMonitorNode {
connection_store_.updateConnection(connection);
}
- protected:
- std::shared_ptr<state::response::FlowVersion> flow_version_;
- ConnectionStore connection_store_;
-};
-
-/**
- * Justification and Purpose: Provides flow version Information
- */
-class FlowInformation : public FlowMonitor {
- public:
- FlowInformation(std::string_view name, const utils::Identifier &uuid)
- : FlowMonitor(name, uuid) {
- }
-
- explicit FlowInformation(std::string_view name)
- : FlowMonitor(name) {
- }
-
- MINIFIAPI static constexpr const char* Description = "Metric node that
defines the flow ID and flow URL deployed to this agent";
-
- std::string getName() const override {
- return "flowInfo";
+ void setProcessors(std::vector<core::Processor*> processors) {
Review Comment:
The processors come from the ProcessGroup's stored processor list, where it
shouldn't be null, but unfortunately they are not enforced with not_null. Here
the processor pointers are checked if they are null where they are used on line
FlowInformation.cpp:67 and FlowInformation.cpp:102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
