tpalfy commented on PR #9640:
URL: https://github.com/apache/nifi/pull/9640#issuecomment-2602790488
Thanks for this update @exceptionfactory and @pvillard31 for the extensive
testing.
I'm doing a review for the code and planning to test it on Oracle as well.
Would need a couple of days to finish if that's okay.
@exceptionfactory
As I see the essence of the backward compatibility is duplicated in the
processors:
```java
protected DatabaseDialectService getDatabaseDialectService(final
PropertyContext context) {
final DatabaseDialectService databaseDialectService;
final String databaseType = context.getProperty(DB_TYPE).getValue();
if (DatabaseDialectServiceDatabaseAdapter.NAME.equals(databaseType))
{
databaseDialectService =
context.getProperty(DATABASE_DIALECT_SERVICE).asControllerService(DatabaseDialectService.class);
} else {
databaseDialectService = new
DatabaseAdapterDatabaseDialectService(databaseType);
}
return databaseDialectService;
}
```
Could we move the logic into the `DatabaseAdapterDescriptor` class or
somewhere else in one place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
