exceptionfactory commented on code in PR #9660:
URL: https://github.com/apache/nifi/pull/9660#discussion_r1927472869
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java:
##########
@@ -165,6 +168,16 @@ public String getDescription() {
.dependsOn(SCHEMA_ACCESS_STRATEGY,
JsonSchemaStrategy.SCHEMA_CONTENT_PROPERTY)
.build();
+
+ public static final PropertyDescriptor MAX_STRING_LENGTH = new
PropertyDescriptor.Builder()
+ .name("Max String Length")
+ .displayName("Max String Length")
Review Comment:
Since this is a new property, the displayName is not needed.
```suggestion
```
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java:
##########
@@ -199,7 +213,7 @@ public String getDescription() {
REL_FAILURE
);
- private static final ObjectMapper MAPPER = new
ObjectMapper().configure(JsonParser.Feature.ALLOW_COMMENTS, true);
+ private ObjectMapper MAPPER;
Review Comment:
The variable name should be lowercased to `mapper` since it is no longer
static.
```suggestion
private ObjectMapper mapper;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
