scottyaslan commented on code in PR #9613:
URL: https://github.com/apache/nifi/pull/9613#discussion_r1927805622
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/ui/canvas/items/process-group/create-process-group/create-process-group.component.html:
##########
@@ -32,25 +32,45 @@ <h2 mat-dialog-title>Create Process Group</h2>
</button>
</mat-form-field>
@if (!flowDefinition) {
- <mat-form-field>
- <mat-label>Parameter Context</mat-label>
- <mat-select formControlName="newProcessGroupParameterContext">
- @for (option of parameterContextsOptions; track option) {
- @if (option.description) {
- <mat-option
- [value]="option.value"
- nifiTooltip
- [tooltipComponentType]="TextTip"
- [tooltipInputData]="option.description"
- [delayClose]="false"
- >{{ option.text }}</mat-option
- >
- } @else {
- <mat-option [value]="option.value">{{ option.text
}}</mat-option>
+ <div class="flex flew-row w-full justify-start items-start">
+ <mat-form-field>
+ <mat-label>Parameter Context</mat-label>
+ <mat-select
formControlName="newProcessGroupParameterContext">
+ <mat-option
+ [value]="null"
+ nifiTooltip
+ [tooltipComponentType]="TextTip"
+ [tooltipInputData]="'No parameter context'"
+ [delayClose]="false"
+ >No parameter context
+ </mat-option>
+ @for (option of parameterContextsOptions |
sortObjectByProperty: 'text'; track option.value) {
+ @if (option.description) {
+ <mat-option
+ [value]="option.value"
+ nifiTooltip
+ [disabled]="option.disabled"
+ [tooltipComponentType]="TextTip"
+ [tooltipInputData]="option.description"
+ [delayClose]="false"
+ >{{ option.text }}</mat-option
+ >
+ } @else {
+ <mat-option [value]="option.value"
[disabled]="option.disabled">{{
+ option.text
+ }}</mat-option>
+ }
}
- }
- </mat-select>
- </mat-form-field>
+ </mat-select>
+ </mat-form-field>
+ <button
+ mat-icon-button
+ class="primary-icon-button mt-1 ml-1"
+ (click)="openNewParameterContextDialog()"
+ title="Create parameter context">
+ <i class="fa fa-plus"></i>
+ </button>
Review Comment:
Good idea.
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/ui/canvas/items/process-group/edit-process-group/edit-process-group.component.html:
##########
@@ -42,18 +54,29 @@ <h2 mat-dialog-title>{{ readonly ? 'Process Group Details'
: 'Edit Process Group
[tooltipComponentType]="TextTip"
[tooltipInputData]="option.description"
[delayClose]="false"
- >{{ option.text }}</mat-option
- >
+ >{{ option.text }}
+ </mat-option>
} @else {
<mat-option
[value]="option.value"
[disabled]="readonly ||
option.disabled"
- >{{ option.text }}</mat-option
- >
+ nifiTooltip
+
[tooltipComponentType]="TextTip"
+
[tooltipInputData]="option.text"
+ [delayClose]="false"
+ >{{ option.text }}
+ </mat-option>
}
}
</mat-select>
</mat-form-field>
+ <button
+ mat-icon-button
+ class="primary-icon-button mt-1 ml-1"
+ (click)="openNewParameterContextDialog()"
+ title="Create parameter context">
+ <i class="fa fa-plus"></i>
+ </button>
Review Comment:
Good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
