rfellows commented on code in PR #9492:
URL: https://github.com/apache/nifi/pull/9492#discussion_r1929151249
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/queue/ui/queue-listing/flowfile-dialog/flowfile-dialog.component.html:
##########
@@ -207,12 +207,7 @@ <h2 mat-dialog-title>FlowFile</h2>
<div class="unset neutral-color">Empty string set</div>
</ng-container>
<ng-template #nonEmptyValue>
- <div class="tertiary-color font-medium" *ngIf="title == null;
else valueWithTitle">
- {{ value }}
- </div>
- <ng-template #valueWithTitle>
- <div class="tertiary-color font-medium" [title]="title">{{
value }}</div>
- </ng-template>
+ <div class="tertiary-color font-medium truncate"
[title]="value">{{ value }}</div>
Review Comment:
title can be supplied to the outer template `#formatValue` but we are now
not using it if supplied. Was that intended? The same comment would apply to
the other similar changes made in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
