markobean commented on PR #9664: URL: https://github.com/apache/nifi/pull/9664#issuecomment-2616464480
I implemented this Flow Analysis Rule in a running NiFi. It worked great with just one nit-picky exception: The time for expiration is normalized to seconds. Technically speaking, expiration time can be in sub-seconds. In reality, this makes very little sense to have such fine-grained resolution. Perhaps, the most appropriate solution should be to have the expiration validation disallow sub-second resolution. I only point it out because the rules do break if if sub-second expiration is specified. I am not recommending changing the analysis rule though. Great updates/improvements in the PR which affected existing flow analysis rule, `RestrictBackpressureSettings`. It makes things a bit cleaner and takes advantage of some Java 21 mechanisms. There remains an issue where the 'Go to component' takes you to the upstream component rather than the affected Connection. However, this can be resolved in a separate PR, not here. Great work, and only a single extremely minor comment on the unit test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
