rfellows commented on code in PR #9492:
URL: https://github.com/apache/nifi/pull/9492#discussion_r1931082767
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/provenance-event-dialog/provenance-event-dialog.component.html:
##########
@@ -425,15 +485,11 @@ <h2 mat-dialog-title>Provenance Event</h2>
<div class="unset neutral-color">Empty string set</div>
</ng-container>
<ng-template #nonEmptyValue>
- <div
- class="tertiary-color font-medium overflow-ellipsis
overflow-hidden whitespace-nowrap"
- *ngIf="title == null; else valueWithTitle">
+ <div class="tertiary-color font-medium" *ngIf="title == null;
else valueWithTitle">
Review Comment:
Is there a reason we wouldn't `truncate` this as well?
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/provenance-event-dialog/provenance-event-dialog.component.html:
##########
@@ -451,15 +507,12 @@ <h2 mat-dialog-title>Provenance Event</h2>
<ng-template #nonEmptyValue>
<div
[copy]="value"
- class="tertiary-color font-medium overflow-ellipsis
overflow-hidden whitespace-nowrap"
+ class="tertiary-color font-medium"
Review Comment:
missing `truncate`?
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/provenance-event-dialog/provenance-event-dialog.component.html:
##########
@@ -471,15 +524,11 @@ <h2 mat-dialog-title>Provenance Event</h2>
</ng-template>
<ng-template #formatContentValue let-value let-title="title">
<ng-container *ngIf="value != null; else nullValue">
- <div
- class="tertiary-color font-medium overflow-ellipsis
overflow-hidden whitespace-nowrap"
- *ngIf="title == null; else valueWithTitle">
+ <div class="tertiary-color font-medium" *ngIf="title == null; else
valueWithTitle">
Review Comment:
missing `truncate`?
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/provenance-event-dialog/provenance-event-dialog.component.html:
##########
@@ -490,17 +539,11 @@ <h2 mat-dialog-title>Provenance Event</h2>
</ng-template>
<ng-template #formatCopyableContentValue let-value let-title="title">
<ng-container *ngIf="value != null; else nullValue">
- <div
- [copy]="value"
- class="tertiary-color font-medium overflow-ellipsis
overflow-hidden whitespace-nowrap"
- *ngIf="title == null; else valueWithTitle">
+ <div [copy]="value" class="tertiary-color font-medium"
*ngIf="title == null; else valueWithTitle">
Review Comment:
missing `truncate`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
