[
https://issues.apache.org/jira/browse/NIFI-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922747#comment-17922747
]
Daniel Stieglitz edited comment on NIFI-14201 at 1/31/25 4:16 PM:
------------------------------------------------------------------
[~exceptionfactory] I had to make changes in RedisUtils (line 466) which uses
redis.clients.jedis.JedisPoolConfig and it inherits from
org.apache.commons.pool2.impl.BaseObjectPoolConfig
and that is where setMinEvictableIdleTime is deprecated and it is suggested to
use setMinEvictableIdleDuration. Apache NIFI has a pojo named
org.apache.nifi.redis.util.RedisConfig which has a corresponding field named
minEvictableIdleTime which is where the old method setMinEvictableIdleTime and
the new method setMinEvictableIdleDuration get its value. Should I change that
variable name to minEvictableIdleDuration or leave as is?
was (Author: JIRAUSER294662):
[~exceptionfactory] I had to make changes in RedisUtils (line 466) which uses
redis.clients.jedis.JedisPoolConfig and it inherits from
org.apache.commons.pool2.impl.BaseObjectPoolConfig
and that is where setMinEvictableIdleTime is deprecated and it is suggested to
use setMinEvictableIdleDuration. Apache NIFI has a pojo named
org.apache.nifi.redis.util.RedisConfig which has a corresponding field named
minEvictableIdleTime which is where the set method get its value. Should I
change that variable name to minEvictableIdleDuration or leave as is?
> Replace deprecated methods in
> org.springframework.data.redis.connection.DefaultedRedisConnection with
> suggested replacements
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-14201
> URL: https://issues.apache.org/jira/browse/NIFI-14201
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Daniel Stieglitz
> Assignee: Daniel Stieglitz
> Priority: Minor
>
> The use of org.springframework.data.redis.connection.DefaultedRedisConnection
> in nifi-redis-bundle is producing the following warnings when building the
> code. These deprecated methods should be replaced with the suggested
> replacements found in the
> [javadoc|https://javadoc.io/doc/org.springframework.data/spring-data-redis/3.4.1/spring.data.redis/org/springframework/data/redis/connection/DefaultedRedisConnection.html].
> {code:java}
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-utils/src/main/java/org/apache/nifi/redis/util/RedisUtils.java:[466,18]
> [deprecation] setMinEvictableIdleTime(Duration) in BaseObjectPoolConfig has
> been deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/SimpleRedisDistributedMapCacheClientService.java:[87,41]
> [deprecation] setNX(byte[],byte[]) in DefaultedRedisConnection has been
> deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/SimpleRedisDistributedMapCacheClientService.java:[90,31]
> [deprecation] expire(byte[],long) in DefaultedRedisConnection has been
> deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/SimpleRedisDistributedMapCacheClientService.java:[104,60]
> [deprecation] get(byte[]) in DefaultedRedisConnection has been deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/SimpleRedisDistributedMapCacheClientService.java:[108,31]
> [deprecation] setNX(byte[],byte[]) in DefaultedRedisConnection has been
> deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/SimpleRedisDistributedMapCacheClientService.java:[112,35]
> [deprecation] expire(byte[],long) in DefaultedRedisConnection has been
> deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/SimpleRedisDistributedMapCacheClientService.java:[142,34]
> [deprecation] exists(byte[]) in DefaultedRedisConnection has been deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/SimpleRedisDistributedMapCacheClientService.java:[150,27]
> [deprecation] set(byte[],byte[],Expiration,SetOption) in
> DefaultedRedisConnection has been deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/SimpleRedisDistributedMapCacheClientService.java:[169,31]
> [deprecation] mSet(Map<byte[],byte[]>) in DefaultedRedisConnection has been
> deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/SimpleRedisDistributedMapCacheClientService.java:[171,64]
> [deprecation] expire(byte[],long) in DefaultedRedisConnection has been
> deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/SimpleRedisDistributedMapCacheClientService.java:[182,44]
> [deprecation] get(byte[]) in DefaultedRedisConnection has been deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/SimpleRedisDistributedMapCacheClientService.java:[196,51]
> [deprecation] del(byte[]...) in DefaultedRedisConnection has been deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/RedisDistributedMapCacheClientService.java:[71,44]
> [deprecation] get(byte[]) in DefaultedRedisConnection has been deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/RedisDistributedMapCacheClientService.java:[100,52]
> [deprecation] get(byte[]) in DefaultedRedisConnection has been deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/RedisDistributedMapCacheClientService.java:[109,31]
> [deprecation] getSet(byte[],byte[]) in DefaultedRedisConnection has been
> deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/RedisDistributedMapCacheClientService.java:[114,35]
> [deprecation] expire(byte[],long) in DefaultedRedisConnection has been
> deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/state/RedisStateProvider.java:[214,48]
> [deprecation] get(byte[]) in DefaultedRedisConnection has been deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/state/RedisStateProvider.java:[237,52]
> [deprecation] get(byte[]) in DefaultedRedisConnection has been deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/state/RedisStateProvider.java:[256,31]
> [deprecation] getSet(byte[],byte[]) in DefaultedRedisConnection has been
> deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/state/RedisStateProvider.java:[296,27]
> [deprecation] del(byte[]...) in DefaultedRedisConnection has been deprecated
> [WARNING]
> nifi-2.2.0/nifi-extension-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/state/RedisStateProvider.java:[323,52]
> [deprecation] keys(byte[]) in DefaultedRedisConnection has been
> deprecated{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
