fgerlits commented on code in PR #1922:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1922#discussion_r1948921908
##########
docker/test/integration/cluster/ImageStore.py:
##########
@@ -150,7 +149,7 @@ def
__build_minifi_cpp_image_with_nifi_python_processors(self, python_option):
elif python_option == PythonOptions.REQUIREMENTS_FILE:
requirements_install_command = "echo 'langchain<=0.17.0' >
/opt/minifi/minifi-current/minifi-python/nifi_python_processors/requirements.txt
&& \\"
elif python_option == PythonOptions.INLINE_DEFINED_PACKAGES:
- parse_document_sed_cmd = parse_document_sed_cmd[:-2] + ' sed -i
"54 i \\ \\ \\ \\ \\ \\ \\ \\ dependencies = [\\\"langchain<=0.17.0\\\"]"
/opt/minifi/minifi-current/minifi-python/nifi_python_processors/ParseDocument.py
&& \\'
+ parse_document_sed_cmd = parse_document_sed_cmd[:-2] + ' sed -i
"s/langchain==0.1.7/langchain<=0.17.0/"
/opt/minifi/minifi-current/minifi-python/nifi_python_processors/ParseDocument.py
&& \\'
Review Comment:
we could do eg. `s/langchain==[0-9.]\\+/langchain<=0.17.0/` so it won't
break if the upstream dependency changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
