pvillard31 commented on code in PR #9713:
URL: https://github.com/apache/nifi/pull/9713#discussion_r1951451059
##########
nifi-extension-bundles/nifi-slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/processors/slack/ListenSlack.java:
##########
@@ -183,8 +187,11 @@ public void establishWebsocketEndpoint(final
ProcessContext context) throws Exce
// Register the event types that make sense
if
(context.getProperty(EVENT_TYPE).getValue().equals(RECEIVE_MESSAGE_EVENTS.getValue()))
{
slackApp.event(MessageEvent.class, this::handleEvent);
+ slackApp.event(MessageChangedEvent.class, this::handleEvent);
slackApp.event(MessageFileShareEvent.class, this::handleEvent);
slackApp.event(FileSharedEvent.class, this::handleEvent);
+ slackApp.event(FileChangeEvent.class, this::handleEvent);
+ slackApp.event(ReactionAddedEvent.class, this::handleEvent);
Review Comment:
As we are adding those, would it make sense to also add:
- MessageDeletedEvent
- ReactionRemovedEvent
- FileCreatedEvent
- FileDeletedEvent
- FilePublicEvent
- FileSharedEvent
- FileUnsharedEvent
This way we are more exhaustive on what relates to messages, files and
reactions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
