[
https://issues.apache.org/jira/browse/NIFI-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838054#comment-15838054
]
ASF GitHub Bot commented on NIFI-3295:
--------------------------------------
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/1444
NIFI-3295 - ensures node is disconnected before trying to remove it
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-3295
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1444.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1444
----
----
> Node Reconnects When Deleting through API
> -----------------------------------------
>
> Key: NIFI-3295
> URL: https://issues.apache.org/jira/browse/NIFI-3295
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.0.1
> Reporter: Josh Meyer
> Priority: Minor
>
> When deleting a node using the API a 200 code is returned, but the node will
> be reconnected. It seems as if it is required to first disconnect the node
> and then delete then node. It would be nice if a 400 code (invalid request)
> or something like this was returned explaining the error.
> Reproduce the node being deleted and reconnecting:
> {code}
> curl -X DELETE -k -v -i
> '<nifi-host>:9091/nifi-api/controller/cluster/nodes/<node-uuid>' --cert
> <path-to-keystore>:<keystore-password>
> {code}
> Getting the deletion to stick:
> {code}
> curl -X PUT -k -v -i
> '<nifi-host>:9091/nifi-api/controller/cluster/nodes/<node-uuid>' -H 'Origin:
> <nifi-host>:9091' -H 'Content-Type: application/json' --data-binary
> '{"node":{"nodeId":"<node-uuid>","status":"DISCONNECTING"}}' --cert
> <path-to-keystore>:<keystore-password>
> curl -X DELETE -k -v -i
> '<nifi-host>:9091/nifi-api/controller/cluster/nodes/<node-uuid>' --cert
> <path-to-keystore>:<keystore-password>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
