exceptionfactory commented on code in PR #9720:
URL: https://github.com/apache/nifi/pull/9720#discussion_r1967949114
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java:
##########
@@ -103,7 +103,8 @@ public abstract class AbstractExecuteSQL extends
AbstractProcessor {
public static final PropertyDescriptor SQL_SELECT_QUERY = new
PropertyDescriptor.Builder()
.name("SQL select query")
- .description("The SQL select query to execute. The query can be
empty, a constant value, or built from attributes "
+ .displayName("SQL Query")
Review Comment:
Instead of adding the `displayName`, recommend using `migrateProperties()`
to change the name of this property.
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java:
##########
@@ -188,6 +189,17 @@ public abstract class AbstractExecuteSQL extends
AbstractProcessor {
.required(true)
.build();
+ public static final PropertyDescriptor OVERWRITE_FLOW_FILE_CONTENT = new
PropertyDescriptor.Builder()
+ .name("Overwrite FlowFile Content")
Review Comment:
Rather than introducing a Boolean property, it seems like it would be better
to call this something like `Content Output Strategy`, with values such as
`Results` and `Ignored`. That would provide more potential for future
flexibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
