mcgilman commented on code in PR #9733: URL: https://github.com/apache/nifi/pull/9733#discussion_r1971946124
########## nifi-frontend/src/main/frontend/apps/nifi-jolt-transform-ui/src/styles.scss: ########## @@ -28,13 +28,7 @@ @use 'codemirror/addon/lint/lint.css'; @use 'font-awesome'; -@use 'libs/shared/src/assets/themes/material'; - -// Include the common styles for Angular Material. We include this here so that you only -// have to load a single css file for Angular Material in your app. -// Be sure that you only ever include this mixin once! -@include mat.elevation-classes(); -@include mat.app-background(); +@use '../../../libs/shared/src/assets/themes/material'; Review Comment: Should we keep the non-relative path here? ########## nifi-frontend/src/main/frontend/apps/standard-content-viewer/src/styles.scss: ########## @@ -28,13 +28,7 @@ @use 'codemirror/addon/fold/foldgutter.css'; @use 'font-awesome'; -@use 'libs/shared/src/assets/themes/material'; - -// Include the common styles for Angular Material. We include this here so that you only -// have to load a single css file for Angular Material in your app. -// Be sure that you only ever include this mixin once! -@include mat.elevation-classes(); -@include mat.app-background(); +@use '../../../libs/shared/src/assets/themes/material'; Review Comment: Should we keep the non-relative path here? ########## nifi-frontend/src/main/frontend/apps/update-attribute/src/styles.scss: ########## @@ -33,13 +33,7 @@ @use 'codemirror/addon/hint/show-hint.css'; @use 'font-awesome'; -@use 'libs/shared/src/assets/themes/material'; - -// Include the common styles for Angular Material. We include this here so that you only -// have to load a single css file for Angular Material in your app. -// Be sure that you only ever include this mixin once! -@include mat.elevation-classes(); -@include mat.app-background(); +@use '../../../libs/shared/src/assets/themes/material'; Review Comment: Should we keep the non-relative path here? ########## nifi-frontend/src/main/frontend/apps/nifi/src/styles.scss: ########## @@ -64,13 +64,7 @@ @use 'codemirror/addon/hint/show-hint.css'; @use 'font-awesome'; -@use 'libs/shared/src/assets/themes/material'; - -// Include the common styles for Angular Material. We include this here so that you only -// have to load a single css file for Angular Material in your app. -// Be sure that you only ever include this mixin once! -@include mat.elevation-classes(); -@include mat.app-background(); +@use '../../../libs/shared/src/assets/themes/material'; Review Comment: Should we keep the non-relative path here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
