ChrisSamo632 commented on PR #9716: URL: https://github.com/apache/nifi/pull/9716#issuecomment-2689283142
> > is there anything stopping us adding `-D frontend.skipTests=false` to the [ci-workflow] > > UI unit tests are deliberately skipped for now. Mainly due to the fact that any commit, no matter what was changed would then execute the UI unit tests and add extra time to the build. The tests have gotten faster, but until we can only build the UI bits when the UI bits change, we will probably keep them off. @rfellows the counter to that argument is that it's how the checks work for all other modules currently (i.e. a change runs the tests for everything), and omitting the UI tests comes with risk of things breaking unknowingly How about adding the UI tests into the integration or system test workflows, or creating a separate UI test workflow, if adding a little extra time to the standard ci workflow is deemed too much? I still don't mean to detract from this PR - once @alex-okrushko has addressed the test failures for the PR, I've no objection to this change being merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
