exceptionfactory commented on code in PR #9754:
URL: https://github.com/apache/nifi/pull/9754#discussion_r1979656493
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/stream/ConsumeKinesisStream.java:
##########
@@ -847,4 +852,23 @@ private Date getStartStreamTimestamp(final PropertyContext
context, final DateTi
protected KinesisAsyncClientBuilder createClientBuilder(final
ProcessContext context) {
return KinesisAsyncClient.builder();
}
+
+ @Override
+ protected void customizeAsyncHttpClientBuilderConfiguration(
+ final ProcessContext context,
+ final NettyNioAsyncHttpClient.Builder builder,
+ final Class<? extends AwsClientBuilder> customizationTargetClass) {
+ if
(KinesisAsyncClientBuilder.class.isAssignableFrom(customizationTargetClass)) {
+ // suggested values from KinesisClientUtil
+ final int initialWindowSizeBytes = 512 * 1024; // 512 KB
Review Comment:
Recommend defining this as a static member variable.
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/stream/ConsumeKinesisStream.java:
##########
@@ -847,4 +852,23 @@ private Date getStartStreamTimestamp(final PropertyContext
context, final DateTi
protected KinesisAsyncClientBuilder createClientBuilder(final
ProcessContext context) {
return KinesisAsyncClient.builder();
}
+
+ @Override
+ protected void customizeAsyncHttpClientBuilderConfiguration(
+ final ProcessContext context,
+ final NettyNioAsyncHttpClient.Builder builder,
+ final Class<? extends AwsClientBuilder> customizationTargetClass) {
+ if
(KinesisAsyncClientBuilder.class.isAssignableFrom(customizationTargetClass)) {
+ // suggested values from KinesisClientUtil
+ final int initialWindowSizeBytes = 512 * 1024; // 512 KB
+ final long healthCheckPingPeriodMillis = 60 * 1000;
Review Comment:
Instead of defining this and then calling `Duration.ofMillis()`, the
`Duration` could be declared as a static member variable as
`Duration.ofMinutes(1)` named `HEALTH_CHECK_PING_PERIOD`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
