lordgamez commented on code in PR #1915:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1915#discussion_r1981527829
##########
libminifi/include/core/ParameterProvider.h:
##########
@@ -65,16 +65,23 @@ class ParameterProvider : public ConfigurableComponentImpl,
public CoreComponent
MINIFIAPI static constexpr auto SensitiveParameterList =
core::PropertyDefinitionBuilder<>::createProperty("Sensitive Parameter List")
.withDescription("List of sensitive parameters, if 'Sensitive Parameter
Scope' is set to 'selected'.")
.build();
+ MINIFIAPI static constexpr auto ReloadValuesOnRestart =
core::PropertyDefinitionBuilder<>::createProperty("Reload Values On Restart")
+ .withDescription("Reload provider generated parameter context values on
restart")
Review Comment:
Updated in
https://github.com/apache/nifi-minifi-cpp/pull/1915/commits/24d6c5e83dc57f46f068cda632d1bde8ba5d969e
##########
libminifi/src/core/json/JsonFlowSerializer.cpp:
##########
@@ -53,20 +53,11 @@ void
JsonFlowSerializer::addProviderCreatedParameterContexts(rapidjson::Value& f
}
std::unordered_set<std::string> parameter_context_names;
Review Comment:
Updated in
https://github.com/apache/nifi-minifi-cpp/pull/1915/commits/24d6c5e83dc57f46f068cda632d1bde8ba5d969e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]