szaszm commented on code in PR #1925:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1925#discussion_r1981745145
##########
minifi_main/MiNiFiMain.cpp:
##########
Review Comment:
I think the new functions should be extracted to a separate file.
##########
cmake/BundledOpenSSL.cmake:
##########
@@ -59,7 +65,8 @@ function(use_openssl SOURCE_DIR BINARY_DIR)
no-module # disable dynamically loadable engines
no-pinshared # don't pin shared libraries in the process
memory
enable-tfo # Enable TCP Fast Open
- no-ssl) # disable SSLv3
+ no-ssl # disable SSLv3
+ no-engine)
Review Comment:
What does this exactly do? INSTALL.md says:
> Don't build support for loading engines.
But I'm not sure what loadable engines are. Is it related to FIPS in any
way? Also, the FIPS target omits most of these, probably leading to some
unnecessary extra build steps, consider adding some more options there, like
no-tests, no-docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
