Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1417#discussion_r97921016
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-api/src/main/java/org/apache/nifi/dbcp/DBCPService.java
 ---
    @@ -31,4 +33,6 @@
     @CapabilityDescription("Provides Database Connection Pooling Service. 
Connections can be asked from pool and returned after usage.")
     public interface DBCPService extends ControllerService {
         public Connection getConnection()  throws ProcessException;
    +
    +    public DataSource getDataSource()  throws ProcessException;
    --- End diff --
    
    If we declare getDataSource() method with default implementation like 
below, we don't have to touch every existing implementation codes in test 
classes:
    
    ```
        default DataSource getDataSource()  throws ProcessException {
            throw new UnsupportedOperationException();
        }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to