[
https://issues.apache.org/jira/browse/NIFI-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839071#comment-15839071
]
ASF GitHub Bot commented on NIFI-3339:
--------------------------------------
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1417#discussion_r97919769
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/test/java/org/apache/nifi/processors/hive/TestPutHiveQL.java
---
@@ -493,8 +496,12 @@ public void testRetryableFailure() throws
InitializationException, ProcessExcept
private static class MockDBCPService extends AbstractControllerService
implements HiveDBCPService {
private final String dbLocation;
+ BasicDataSource dataSource = new BasicDataSource();
+
--- End diff --
Travis build is failing due to check-style error.
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:2.15:check (check-style) on
project nifi-hive-processors: You have 2 Checkstyle violations. -> [Help 1]
```
Please run `mvn -Pcontrib-check clean install` at the root nifi folder to
ensure there's no check-style issue.
You can find error detail in target/checkstyle-result.xml created in each
project, looks like below:
```
<file
name="/Users/koji/dev/nifi/nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/test/java/org/apache/nifi/processors/hive/TestPutHiveQL.java">
<error line="500" severity="warning" message="Line has trailing
whitespace."
source="com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck"/>
</file>
```
> Add getDataSource() to DBCPService
> ----------------------------------
>
> Key: NIFI-3339
> URL: https://issues.apache.org/jira/browse/NIFI-3339
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Toivo Adams
> Assignee: Toivo Adams
> Priority: Minor
>
> Currently DBCPService returns only Connection.
> Sometimes DataSource is needed, for example Spring JdbcTemplate,
> SimpleJdbcCall need DataSource.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
