awelless commented on code in PR #9801:
URL: https://github.com/apache/nifi/pull/9801#discussion_r1993418256
##########
nifi-extension-bundles/nifi-box-bundle/nifi-box-processors/src/test/java/org/apache/nifi/processors/box/GetBoxFileCollaboratorsTest.java:
##########
@@ -239,6 +247,37 @@ void testGetCollaborationsWithMultipleRoles() {
flowFilesFirst.assertAttributeEquals("box.collaborations.accepted.viewer.users.logins",
TEST_USER_EMAIL_3);
}
+ @Test
+ void testGetCollaborationsForAllViewingRoles() {
+ testRunner.setProperty(GetBoxFileCollaborators.FILE_ID, TEST_FILE_ID);
+ testRunner.setProperty(GetBoxFileCollaborators.ROLES,
"owner,co-owner,editor,viewer uploader,viewer");
+ testRunner.setProperty(GetBoxFileCollaborators.STATUSES, "accepted");
+
+ setupCollaborator(mockCollabInfo1, mockUserInfo1, USER,
TEST_USER_ID_1, ACCEPTED, CO_OWNER);
+ setupCollaborator(mockCollabInfo2, mockUserInfo2, USER,
TEST_USER_ID_2, ACCEPTED, EDITOR);
+ setupCollaborator(mockCollabInfo3, mockUserInfo3, USER,
TEST_USER_ID_3, ACCEPTED, VIEWER);
+ setupCollaborator(mockCollabInfo4, mockGroupInfo1, GROUP,
TEST_GROUP_ID_1, ACCEPTED, VIEWER_UPLOADER);
+ setupCollaborator(mockCollabInfo5, mockGroupInfo2, GROUP,
TEST_GROUP_ID_2, ACCEPTED, PREVIEWER);
+ setupFileCollaborations();
+
+ testRunner.enqueue(new MockFlowFile(0));
+ testRunner.run();
+
+
testRunner.assertAllFlowFilesTransferred(GetBoxFileCollaborators.REL_SUCCESS,
1);
+ final List<MockFlowFile> flowFiles =
testRunner.getFlowFilesForRelationship(GetBoxFileCollaborators.REL_SUCCESS);
+ final MockFlowFile flowFilesFirst = flowFiles.getFirst();
+
+ flowFilesFirst.assertAttributeEquals("box.collaborations.count", "5");
+
flowFilesFirst.assertAttributeEquals("box.collaborations.accepted.co-owner.users.ids",
TEST_USER_ID_1);
+
flowFilesFirst.assertAttributeEquals("box.collaborations.accepted.co-owner.users.logins",
TEST_USER_EMAIL_1);
+
flowFilesFirst.assertAttributeEquals("box.collaborations.accepted.editor.users.ids",
TEST_USER_ID_2);
+
flowFilesFirst.assertAttributeEquals("box.collaborations.accepted.editor.users.logins",
TEST_USER_EMAIL_2);
+
flowFilesFirst.assertAttributeEquals("box.collaborations.accepted.viewer.users.ids",
TEST_USER_ID_3);
+
flowFilesFirst.assertAttributeEquals("box.collaborations.accepted.viewer.users.logins",
TEST_USER_EMAIL_3);
+
flowFilesFirst.assertAttributeEquals("box.collaborations.accepted.viewer
uploader.groups.ids", TEST_GROUP_ID_1);
+
flowFilesFirst.assertAttributeEquals("box.collaborations.accepted.viewer
uploader.groups.emails", TEST_GROUP_EMAIL_1);
Review Comment:
I reckon that attribute names should be consistent with [Box
roles](https://developer.box.com/guides/collaborations/). Even when they
contain hyphens or spaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
