dan-s1 commented on code in PR #9785:
URL: https://github.com/apache/nifi/pull/9785#discussion_r1993547767
##########
nifi-extension-bundles/nifi-jolt-bundle/nifi-jolt-processors/src/test/java/org/apache/nifi/processors/jolt/TestJoltTransformJSON.java:
##########
@@ -464,6 +464,71 @@ void testJoltSpecInvalidEL() throws IOException {
runner.assertNotValid();
}
+ @Test
Review Comment:
@exceptionfactory I see 4 new unit tests which are configured very
similarly. Do you think these four tests should be folded into a JUnit5
`ParamaterizedTest` and use the `MethodSource` annotation to define a method
which would return the necessary arguments for each of these tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
