fgerlits commented on code in PR #1926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1926#discussion_r1995281061
##########
extensions/kafka/ConsumeKafka.h:
##########
@@ -23,26 +23,27 @@
#include <utility>
#include <vector>
-#include "KafkaConnection.h"
#include "KafkaProcessorBase.h"
+#include "core/logging/LoggerFactory.h"
#include "core/PropertyDefinition.h"
#include "core/PropertyDefinitionBuilder.h"
#include "core/PropertyType.h"
#include "core/RelationshipDefinition.h"
-#include "core/logging/LoggerFactory.h"
#include "io/StreamPipe.h"
#include "rdkafka.h"
#include "rdkafka_utils.h"
+#include "KafkaConnection.h"
#include "utils/ArrayUtils.h"
namespace org::apache::nifi::minifi {
namespace core {
-class ConsumeKafkaMaxPollTimePropertyType : public TimePeriodPropertyType {
+class ConsumeKafkaMaxPollTimePropertyType final : public PropertyValidator {
Review Comment:
this will need some more changes, where the validator is used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
