dan-s1 commented on code in PR #4:
URL: https://github.com/apache/nifi-api/pull/4#discussion_r1999737228
##########
src/main/java/org/apache/nifi/documentation/xml/XmlDocumentationWriter.java:
##########
@@ -108,12 +108,12 @@ protected void writeDeprecationNotice(final
DeprecationNotice deprecationNotice)
return;
}
- final Class[] classes = deprecationNotice.alternatives();
+ final Class<?>[] classes = deprecationNotice.alternatives();
final String[] classNames = deprecationNotice.classNames();
final Set<String> alternatives = new LinkedHashSet<>();
if (classes != null) {
Review Comment:
Is this `if` necessary if the default value in the `DeprecationNotice` is
`{}` which is an empty array and not null? Is there some way to specify
`classNames` in the `DeprecationNotice` and it for to be null? Same question
for `classNames`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
