martinzink commented on code in PR #1926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1926#discussion_r2001035535
##########
extensions/standard-processors/tests/unit/GenerateFlowFileTests.cpp:
##########
@@ -102,7 +102,7 @@ TEST_CASE("GenerateFlowFileCustomTextEmptyTest") {
constexpr int32_t file_size = 10;
- test_controller.plan->setProperty(generate_flow_file,
GenerateFlowFile::FileSize, std::to_string(file_size));
+ CHECK(test_controller.plan->setProperty(generate_flow_file,
GenerateFlowFile::FileSize, std::to_string(file_size)));
Review Comment:
probably just some leftover from debugging, but now that you mentioned i've
added everywhere in
[GenerateFlowFileTests](https://github.com/apache/nifi-minifi-cpp/pull/1926/commits/49105305dfb8b6d79cf84f5ecc88233d05e7a6ea)
(we should probably add [[nodiscard]] to setProperty and check in every test)
but thats probably out of the scope of this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
