[
https://issues.apache.org/jira/browse/NIFI-14426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940728#comment-17940728
]
Piotr Zalas commented on NIFI-14426:
------------------------------------
Hi [~exceptionfactory], this is also my concern that legacy xls format isn't
streamable, which doesn't go in line with current implementation. Looking at
the code, into org.apache.nifi.excel.RowIterator class, it seems that access
interface to files in both new and legacy format is encapsulated in
Workbook interface. So it seems that it wouldn't be hard to use StreamingReader
for new format, while using HSSFWorkbook class for files in legacy format. I
wonder if creating separate reader wouldn't lead to unnecessary code
duplication. On the other hand end user might be surprised that depending on
the file format file reading can consume surprising amount of resources, so
maybe it's better to separate. WDYT?
> Add support for HSSF format in ExcelReader processor
> ----------------------------------------------------
>
> Key: NIFI-14426
> URL: https://issues.apache.org/jira/browse/NIFI-14426
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Piotr Zalas
> Priority: Major
>
> Currently ExcelReader processor supports only files in new XSSF (.xlsx)
> format. Add support for legacy HSSF (.xls) format.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
