Copilot commented on code in PR #1941:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1941#discussion_r2031118778
##########
libminifi/src/c2/ControllerSocketMetricsPublisher.cpp:
##########
@@ -87,6 +89,23 @@ void ControllerSocketMetricsPublisher::loadMetricNodes() {
}
}
+void ControllerSocketMetricsPublisher::setRoot(core::ProcessGroup* root) {
+ flow_status_builder_.setRoot(root);
+}
+
+void
ControllerSocketMetricsPublisher::setFlowStatusDependencies(core::BulletinStore*
bulletin_store, const std::filesystem::path& flowile_repo_dir, const
std::filesystem::path& content_repo_dir) {
+ flow_status_builder_.setBulletinStore(bulletin_store);
+ flow_status_builder_.setRepositoryPaths(flowile_repo_dir, content_repo_dir);
Review Comment:
The parameter name 'flowile_repo_dir' appears to be misspelled. Consider
renaming it to 'flowfile_repo_dir' for clarity.
```suggestion
void
ControllerSocketMetricsPublisher::setFlowStatusDependencies(core::BulletinStore*
bulletin_store, const std::filesystem::path& flowfile_repo_dir, const
std::filesystem::path& content_repo_dir) {
flow_status_builder_.setBulletinStore(bulletin_store);
flow_status_builder_.setRepositoryPaths(flowfile_repo_dir,
content_repo_dir);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
