Copilot commented on code in PR #1959:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1959#discussion_r2031292818
##########
libminifi/test/integration/C2AssetSyncTest.cpp:
##########
@@ -233,17 +238,20 @@ TEST_CASE("C2AssetSync", "[c2test]") {
{(asset_dir / "nested" / "C.txt").string(), file_C},
{(asset_dir / ".state").string(), hb_handler.assetState()}
};
- auto actual_assets = get_asset_structure();
- if (actual_assets != expected_assets) {
- controller.getLogger()->log_error("Mismatch between expected and
actual assets");
- for (auto& [path, content] : expected_assets) {
- controller.getLogger()->log_error("Expected asset at {}: {}", path,
content);
- }
- for (auto& [path, content] : actual_assets) {
- controller.getLogger()->log_error("Actual asset at {}: {}", path,
content);
+ REQUIRE(utils::verifyEventHappenedInPollTime(10s, [&] {
+ auto actual_assets = get_asset_structure();
+ if (actual_assets != expected_assets) {
+ controller.getLogger()->log_error("Mismatch between expected and
actual assets");
+ for (auto& [path, content] : expected_assets) {
+ controller.getLogger()->log_error("Expected asset at {}: {}",
path, content);
+ }
+ for (auto& [path, content] : actual_assets) {
+ controller.getLogger()->log_error("Actual asset at {}: {}", path,
content);
+ }
+ return false;
Review Comment:
Consider adding a clear failure message within the lambda or a comment
explaining this change to improve clarity when the test fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
