exceptionfactory commented on PR #9837: URL: https://github.com/apache/nifi/pull/9837#issuecomment-2789646759
> > As a procedural note, please avoid squashing commits unless requested, or there is some compelling reason to do so, as it makes it difficult to track what changes in the course of the review. > > Wait, I thought that I should do it as the checklist contains - `Pull Request refers to a feature branch with one commit containing changes.` Sorry about that. I actually prefer not to squash commits. > > I also verified that the system tests pass locally - which I did previosly - so I hope the check will pass this time. Thanks, I can see the instructions being confusing. For the initial pull request, one commit is recommended to have a clean starting point, then other commits can be added on. Thanks for the updates, will review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
