mcgilman commented on code in PR #9900:
URL: https://github.com/apache/nifi/pull/9900#discussion_r2061317306
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/ui/manage-remote-ports/manage-remote-ports.component.html:
##########
@@ -219,7 +219,7 @@ <h3 class="primary-color">Manage Remote Ports</h3>
<button
mat-menu-item (click)="toggleTransmission(port)">
<i
class="fa
fa-bullseye transmitting primary-color mr-2"></i>
- Transmitting:
click to toggle port transmission
+ Disable
transmission
Review Comment:
Can we update the icon here as well? I think we're showing the opposite icon
here. For instance when a component is Running and we present the Stop action
we would show a Stop icon too. This menu item is to Disable the remote port so
we should render the Disable icon.
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/ui/manage-remote-ports/manage-remote-ports.component.html:
##########
@@ -228,7 +228,7 @@ <h3 class="primary-color">Manage Remote Ports</h3>
(click)="toggleTransmission(port)">
<i
class="not-transmitting icon icon-transmit-false primary-color mr-2"></i>
- Not
Transmitting: click to toggle port transmission
+ Enable
transmission
Review Comment:
Can we also swap this icon as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
