szaszm commented on code in PR #1963:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1963#discussion_r2063907463
##########
extensions/rocksdb-repos/database/RocksDatabase.h:
##########
@@ -59,8 +59,6 @@ class RocksDatabase {
private:
const std::string column_;
std::shared_ptr<RocksDbInstance> db_;
-
- static std::shared_ptr<core::logging::Logger> logger_;
Review Comment:
what made this necessary? I support the refactor, I'm just interested in the
reason, it's something we might need to take into account during code design in
the future.
##########
libminifi/src/agent/agent_docs.cpp:
##########
@@ -20,15 +20,18 @@
namespace org::apache::nifi::minifi {
namespace {
-std::map<std::string, Components> AgentDocs_class_mappings;
+std::map<std::string, Components>& getAgentDocsClassMappings() {
+ static std::map<std::string, Components> mappings;
+ return mappings;
Review Comment:
same question here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
