szaszm commented on code in PR #1946:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1946#discussion_r2075361065


##########
thirdparty/fmt/add_error_message_to_std__error_code_formatter.patch:
##########


Review Comment:
   Looking at the error code ostream writer operator, it doesn't print the 
message at all. Instead of patching fmt to diverge from that, we should work 
with what we have and print ec.message() instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to