martinzink commented on code in PR #1927:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1927#discussion_r2077535734
##########
extensions/aws/CMakeLists.txt:
##########
@@ -33,14 +33,20 @@ add_minifi_library(minifi-aws SHARED ${SOURCES})
target_link_libraries(minifi-aws PUBLIC ${LIBMINIFI} Threads::Threads)
target_wholearchive_library_private(minifi-aws AWS::aws-cpp-sdk-s3)
+target_wholearchive_library_private(minifi-aws AWS::aws-cpp-sdk-kinesis)
if(CMAKE_SYSTEM_PROCESSOR MATCHES "(arm64)|(ARM64)|(aarch64)|(armv8)")
target_wholearchive_library_private(minifi-aws AWS::aws-checksums)
endif()
-get_target_property(AWS_SDK_INCLUDE_DIRS AWS::aws-cpp-sdk-s3
INTERFACE_INCLUDE_DIRECTORIES)
+get_target_property(AWS_SDK_S3_INCLUDE_DIRS AWS::aws-cpp-sdk-s3
INTERFACE_INCLUDE_DIRECTORIES)
+get_target_property(AWS_SDK_KINESIS_INCLUDE_DIRS AWS::aws-cpp-sdk-kinesis
INTERFACE_INCLUDE_DIRECTORIES)
+
target_include_directories(minifi-aws INTERFACE ${AWS_SDK_INCLUDE_DIRS})
Review Comment:
🤷 good catch though,
https://github.com/apache/nifi-minifi-cpp/pull/1927/commits/3bf6cb8601b1584cdb9ee1c9a252ee97577699da#diff-b651ff98c4c5b9b1cb6772b0451624a0528639aeba8bc4bb6f3b06d7476ecfa4R43
##########
extensions/aws/utils/ProxyOptions.h:
##########
@@ -0,0 +1,35 @@
+/**
+ * @file S3RequestSender.h
+ * S3RequestSender class declaration
+ *
Review Comment:
Good catch, I hate these with a passion. Purged them from aws extension in
https://github.com/apache/nifi-minifi-cpp/commit/3bf6cb8601b1584cdb9ee1c9a252ee97577699da
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
