dan-s1 commented on code in PR #9874:
URL: https://github.com/apache/nifi/pull/9874#discussion_r2079892177
##########
nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/ExcelReader.java:
##########
@@ -85,6 +85,16 @@ public class ExcelReader extends SchemaRegistryService
implements RecordReaderFa
.addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
.build();
+ public static final PropertyDescriptor INPUT_FILE_TYPE = new
PropertyDescriptor
+ .Builder().name("Input File Type")
+ .displayName("Input File Type")
+ .description("Specifies type of Excel input file.")
+ .required(true)
+ .allowableValues(InputFileType.class)
+ .defaultValue(InputFileType.XLSX)
+
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
Review Comment:
For now I think we want the UI to only provide the 2 allowable choices and
not allow for expression language. If expression language is allowed then the
UI will force the user to enter a value and not have a selection box. In a
follow up conversation with @exceptionfactory he was okay to only allow for the
allowable values.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
