scottyaslan commented on code in PR #9855: URL: https://github.com/apache/nifi/pull/9855#discussion_r2080155466
########## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/app.component.html: ########## @@ -0,0 +1,21 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<div class="flex flex-col h-screen"> + <app-header></app-header> Review Comment: The point here is that the text color needs to pass contrast ratio with the background color in both light and dark mode. One option here for the NiFi Registry logo is that we could wrap it in a div or span and give it the legacy Registry header background color and some rounded border radius: <img width="62" alt="Screenshot 2025-05-08 at 1 25 13 PM" src="https://github.com/user-attachments/assets/4493f8b4-0eaa-4e77-88a6-cf43a60c5b87"; /> This would work in both light and dark mode and not require a new logo. As for you thoughts on a shared component: Yes I think leveraging Angular's content projection is a good path to explore. I was thinking you could just move the header from nifi into the shared lib. If you want to do this in a follow on effort I am supportive of that but we need a way to track this work. We need an epic or at least a parent jira with sub-tasks. This way would make it easier to break the work up so others may contribute and it should also lead to smaller more manageable PRs. Big PRs like this are difficult and time consuming to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
